vuepress / core

Vue-Powered Static Site Generator
https://vuepress.vuejs.org
MIT License
2.16k stars 922 forks source link

refactor(markdown): remove codePlugin and add vPrePlugin (close #1550) #1556

Closed pengzhanbo closed 1 month ago

pengzhanbo commented 1 month ago

Before submitting the PR, please make sure you do the following

What is the purpose of this pull request?

Description

See #1550 .

Related PRs:

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9185430779

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/markdown/src/markdown.ts 3 4 75.0%
<!-- Total: 18 19 94.74% -->
Files with Coverage Reduction New Missed Lines %
packages/bundler-webpack/src/config/handleDevtool.ts 1 0.0%
packages/bundler-webpack/src/config/handleOtherOptions.ts 4 0.0%
packages/bundler-webpack/src/build/ssr/createClientPlugin.ts 10 0.0%
packages/bundler-webpack/src/build/createClientConfig.ts 15 0.0%
<!-- Total: 30 -->
Totals Coverage Status
Change from base Build 9168161159: -2.7%
Covered Lines: 624
Relevant Lines: 1646

💛 - Coveralls
Mister-Hope commented 1 month ago

I think you can remove code Plugin entirely in this PR.

Mister-Hope commented 1 month ago

@meteorlxy Test is added, this should be ready.