search

vuepress / core

Vue-Powered Static Site Generator
https://vuepress.vuejs.org
MIT License
2.35k stars 923 forks source link

[Bug report] app.env.isBuild is broken #1612

Closed Mister-Hope closed 1 month ago

Mister-Hope commented 1 month ago

Description

app.env.isBuild is broken, and is affecting downstream plugins.

Also I am curious if there could be a 3rd state besides dev and build in future.....

Reproduction

Not needed

Used Package Manager

npm

System Info

.
Mister-Hope commented 1 month ago

@meteorlxy This is introduced by https://github.com/vuepress/core/commit/be249ec9ccd6de1438662b980b23ebe61a3954aa

This affect the plugins that is using a (app) => pluginApi, where the app here is wrong. The app that could be accessed in hook functions are not affected.

Mister-Hope commented 1 month ago

I suggest revert that commit