search

vuepress / core

Vue-Powered Static Site Generator
https://vuepress.vuejs.org
MIT License
2.33k stars 923 forks source link

[Bug report] Issue with types #22

Closed Mister-Hope closed 3 years ago

Mister-Hope commented 3 years ago

Bug report

https://github.com/vuepress/vuepress-next/blob/607112cd2d8b9536554296470eba20e9e181e661/packages/%40vuepress/theme-default/src/types/options.ts#L2

The DefaultThemeOption is using types from plugin-docsearch, while it is not installed by default.

https://github.com/vuepress/vuepress-next/blob/607112cd2d8b9536554296470eba20e9e181e661/packages/%40vuepress/theme-default/src/node/resolveDocsearchPluginOptions.ts#L19-L20

So errors will be trigged if the plugin is not installed.

meteorlxy commented 3 years ago

Uh nice catch. Maybe we should remove docsearch options from default theme