vuepress / ecosystem

Official plugins and themes for VuePress2
https://ecosystem.vuejs.press
MIT License
20 stars 26 forks source link

feat: init watermark plugin #111

Closed pengzhanbo closed 1 month ago

pengzhanbo commented 1 month ago

Before submitting the PR, please make sure you do the following

What is the purpose of this pull request?

Description

Integrate watermark-js-plus into VuePress。

This plugin can add watermark to the pages, you can choose between add watermark globally or on specific pages. You can also choose between add text watermark or image watermark.

Mister-Hope commented 1 month ago

I think the docs should be detailed telling defineWatermarkConfig can used to add hooks to watermark.

Mister-Hope commented 1 month ago

LGTM, I leave a comment at a check of image, check that, maybe you want to mean or?

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 8969158557

Details


Totals Coverage Status
Change from base Build 8965251344: 0.0%
Covered Lines: 698
Relevant Lines: 1255

💛 - Coveralls
Mister-Hope commented 1 month ago

Currently this PR is blocked by the latest commit at main. I am still figuring out that.

Mister-Hope commented 1 month ago

BTW, could you add some e2e tests?

pengzhanbo commented 1 month ago

BTW, could you add some e2e tests?

When I run pnpm e2e:dev locally, I noticed that the webServer.command in playwright.config.ts is not being executed at all. Playwright starts running the tests without waiting for http://127.0.0.1:9080 to return 200 OK. I have to run pnpm docs:dev first before pnpm e2e:dev runs correctly.

Mister-Hope commented 1 month ago

BTW, could you add some e2e tests?

When I run pnpm e2e:dev locally, I noticed that the webServer.command in playwright.config.ts is not being executed at all. Playwright starts running the tests without waiting for http://127.0.0.1:9080 to return 200 OK. I have to run pnpm docs:dev first before pnpm e2e:dev runs correctly.

yes, anywhere is containing outdated deps and I replaced with http-server, However I haven't made things to work yet, The ci is still falling in main.

If you have time you can help me investigate it, besides, it's welcomed to add my WeChat Mister-Hope

pengzhanbo commented 1 month ago

Fix e2e tests plz

Done

Mister-Hope commented 1 month ago

@pengzhanbo Hi, I rebuild the plugin, and you are welcomed to review this for me.

The rebuild is containing: