Closed pengzhanbo closed 1 month ago
I think the docs should be detailed telling defineWatermarkConfig can used to add hooks to watermark.
LGTM, I leave a comment at a check of image, check that, maybe you want to mean or?
Totals | |
---|---|
Change from base Build 8965251344: | 0.0% |
Covered Lines: | 698 |
Relevant Lines: | 1255 |
Currently this PR is blocked by the latest commit at main. I am still figuring out that.
BTW, could you add some e2e tests?
BTW, could you add some e2e tests?
When I run pnpm e2e:dev
locally, I noticed that the webServer.command
in playwright.config.ts
is not being executed at all. Playwright starts running the tests without waiting for http://127.0.0.1:9080
to return 200 OK
. I have to run pnpm docs:dev
first before pnpm e2e:dev
runs correctly.
BTW, could you add some e2e tests?
When I run
pnpm e2e:dev
locally, I noticed that thewebServer.command
inplaywright.config.ts
is not being executed at all. Playwright starts running the tests without waiting forhttp://127.0.0.1:9080
to return200 OK
. I have to runpnpm docs:dev
first beforepnpm e2e:dev
runs correctly.
yes, anywhere is containing outdated deps and I replaced with http-server, However I haven't made things to work yet, The ci is still falling in main.
If you have time you can help me investigate it, besides, it's welcomed to add my WeChat Mister-Hope
Fix e2e tests plz
Done
@pengzhanbo Hi, I rebuild the plugin, and you are welcomed to review this for me.
The rebuild is containing:
@vuepress/plugin-watermark/client
directly without calling the plugin.global
and filter
with enabled
WatermarkPureOptions
instead of WatermarkAttrOptions
and WatermarkOptions
is only available at client.options.image
issueisInsideApp
to determine whether the parent may be sensitive with routing.
Before submitting the PR, please make sure you do the following
close #123
).What is the purpose of this pull request?
Description
Integrate watermark-js-plus into VuePress。
This plugin can add watermark to the pages, you can choose between add watermark globally or on specific pages. You can also choose between add text watermark or image watermark.