pengzhanbo commented 1 month ago

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

[ ] Bug fix
[x] New feature
[ ] Other

Description

111

Adjust the defineXXXConfig(options) function parameters exported by some plugins, updating the type of the options parameter to MaybeRefOrGetter<XXX>. This allows third parties to have more flexibility in controlling the behavior of the plugins when using them.

plugin-photo-swipe：

- export const definePhotoSwipeConfig = (options: PhotoSwipeOptions)
+ export const definePhotoSwipeConfig = (options: MaybeRefOrGetter<PhotoSwipeOptions>)

plugin-docsearch

- export const defineDocSearchConfig = (options: DocSearchClientOptions)
+ export const defineDocSearchConfig = (options: MaybeRefOrGetter<DocSearchClientOptions>)

plugin-comment

I'm not sure if it's necessary to modify the 'defineXXXConfig' exported by the comment plugin, so I haven't made any changes to them.

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 8965168184

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 50.304%

Totals
Change from base Build 8965163927:	0.0%
Covered Lines:	698
Relevant Lines:	1255

💛 - Coveralls

Mister-Hope commented 1 month ago

plugin-comment

I'm not sure if it's necessary to modify the 'defineXXXConfig' exported by the comment plugin, so I haven't made any changes to them.

That should be edge cases, we can support that if it would not lead some new issues.