perf(plugin-back-to-top): optimize backToTop feature

vuepress / ecosystem

Official plugins and themes for VuePress2

https://ecosystem.vuejs.press

MIT License

20 stars 26 forks source link

perf(plugin-back-to-top): optimize backToTop feature #125

Closed pengzhanbo closed 1 month ago

pengzhanbo commented 1 month ago

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

[ ] Bug fix
[x] New feature
[ ] Other

Description

Adjust the backToTop button, add scrolling progress percentage text, and optimize the interaction effect.

Screenshots

Before

After

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9044992129

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 50.304%

Totals
Change from base Build 9041934374:	0.0%
Covered Lines:	698
Relevant Lines:	1255

💛 - Coveralls

Mister-Hope commented 1 month ago

I'm not pretty sure about your contribution. I already have the percent computed defing the scroll precent, Why should and other similar variable is introduced?

Also there is one more thing to be discussed, In what situation shall people care about the actual and exact percentage that a page has been scrolled?

A progress bar around the icon should have been enough for this situation.