vuepress / ecosystem

Official plugins and themes for VuePress2
https://ecosystem.vuejs.press
MIT License
20 stars 26 forks source link

feat: migrate the `codePlugin` from `@vuepress/markdown` to `plugin-prismjs` #136

Closed pengzhanbo closed 1 month ago

pengzhanbo commented 1 month ago

Before submitting the PR, please make sure you do the following

What is the purpose of this pull request?

Description

see https://github.com/vuepress/core/issues/1550

Screenshots

Before

After

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9124434582

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/plugin-prismjs/src/node/resolveHighlighter.ts 0 2 0.0%
plugins/plugin-prismjs/src/node/prismjsPlugin.ts 0 3 0.0%
<!-- Total: 84 89 94.38% -->
Totals Coverage Status
Change from base Build 9123655949: 2.2%
Covered Lines: 771
Relevant Lines: 1350

💛 - Coveralls
meteorlxy commented 1 month ago

Please also migrate and try to improve the test cases. Code fence plugin is an important feature.

pengzhanbo commented 1 month ago

Please also migrate and try to improve the test cases. Code fence plugin is an important feature.

Added test cases identical to the codePlugin in @vuepress/core.

pengzhanbo commented 1 month ago

The current PR has been merged into #137, so close this PR and continue the discussion in #137.