vuepress / ecosystem

Official plugins and themes for VuePress2
https://ecosystem.vuejs.press
MIT License
20 stars 26 forks source link

feat: add guidelines #139

Open Mister-Hope opened 1 month ago

Mister-Hope commented 1 month ago

@pengzhanbo Need help with the color part.

I don't like the -1 -2 -3 as this will confuse developers and users. They should be something like -hover -bg

For example:

--vp-c-brand
--vp-c-brand-bg
--vp-c-brand-hover

--vp-c-text
--vp-c-mute

You can complete the guidelines, and I will sync the default-theme (classic theme)

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9383177498

Details


Totals Coverage Status
Change from base Build 9381003398: 0.0%
Covered Lines: 992
Relevant Lines: 1582

💛 - Coveralls
pengzhanbo commented 1 month ago

@pengzhanbo Need help with the color part, I don't like the -1 -2 -3 they should be something like `-hover`-bg

For example:

--vp-c-brand
--vp-c-brand-bg
--vp-c-brand-hover

--vp-c-text
--vp-c-mute

You can complete the guidelines, and I will sync the default-theme (classic theme)

@pengzhanbo Need help with the color part, I don't like the -1 -2 -3 they should be something like `-hover`-bg

For example:

--vp-c-brand
--vp-c-brand-bg
--vp-c-brand-hover

--vp-c-text
--vp-c-mute

You can complete the guidelines, and I will sync the default-theme (classic theme)

OK, I am organizing the content.

Mister-Hope commented 1 month ago

The comment plugin still needs an update, probably after adding a useDarkMode in @vuepress/helper and a syncDarkMode helper.

The synDarkMode should be like this:

syncDarkmode(document.documentElement, 'class', { light: '', dark: 'dark' });

syncDarkmode(document.body, 'id', { light: 'light', dark: 'dark' });

It would be helpful if we force the community to use a specific darkmode selector, and provide a "Sync helper" to sync the darkmode state with other light/dark dom combinations in case some component library or other packages are requiring different ones.

pengzhanbo commented 1 month ago

Colors: Palette

The primitive colors used for accent colors. These colors are referenced by functional colors such as "Text", "Background", or "Brand".

Each colors have exact same color scale system with 3 levels of solid colors with different brightness, and 1 soft color.

For Example:

--vp-c-gray: #dddde3;
--vp-c-gray-hover: #e4e4e9;
--vp-c-gray-bg: #ebebef;
--vp-c-gray-soft: rgba(142, 150, 170, 0.14);

Colors: Background

For Example:

--vp-c-bg: #ffffff;
--vp-c-bg-alt: #f6f6f7;
--vp-c-bg-elv: #ffffff;
--vp-c-bg-soft: #f6f6f7;

Colors: Borders

For Example:

--vp-c-border: #c2c2c4;
--vp-c-divider: #e2e2e3;
--vp-c-gutter: #e2e2e3;

Colors: Text

For Example:

--vp-c-text-primary: rgba(60, 60, 67);
--vp-c-text-mute: rgba(60, 60, 67, 0.78);
--vp-c-text-subtle: rgba(60, 60, 67, 0.56);