feat: add `shiki`/`prismjs` class names to differentiate highlight plugins

vuepress / ecosystem

Official plugins and themes for VuePress2

https://ecosystem.vuejs.press

MIT License

19 stars 25 forks source link

feat: add `shiki`/`prismjs` class names to differentiate highlight plugins #181

Closed pengzhanbo closed 4 weeks ago

pengzhanbo commented 1 month ago

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

[ ] Bug fix
[x] New feature
[ ] Other

Description

Screenshots

Before

After

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 9301432327

Details

2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 56.737%

Totals
Change from base Build 9286705501:	-0.02%
Covered Lines:	1003
Relevant Lines:	1583

Since there is already a shiki class on the pre element, I am thinking whether we could add a data-highlighter="shiki|prismjs" instead? This is unified with data-title and data-ext, and avoid the inconstant behavior that shiki is affecting wrapper and pre while prismjs only affects pre.

Mister-Hope commented 4 weeks ago

@pengzhanbo need help here, I try to make some tweaks, but some code blocks are having extra line-numbers-mode