vuepress / ecosystem

Official plugins and themes for VuePress2
https://ecosystem.vuejs.press
MIT License
21 stars 26 forks source link

fix(theme-default): include path in sidebar heading links #82

Closed kvanzuijlen closed 4 months ago

kvanzuijlen commented 4 months ago

Before submitting the PR, please make sure you do the following

What is the purpose of this pull request?

Description

This PR fixes a bug/oversight that caused paths not to be included in the links to headers in the sidebar. Closes #81

Screenshots

Before

image

After

image
Mister-Hope commented 4 months ago

image

The issue should be an / placed before the anchor, and that should be a issue with core, I refuse a workaround like this.

kvanzuijlen commented 4 months ago

I think the changes to isActiveSidebarItem would still be required when this gets solved in vuepress/core though, right?

Mister-Hope commented 3 months ago

No, we perfer a clean anchor rather than a full link. Its just a / is placed before the # by mistake.

kvanzuijlen commented 3 months ago

Ah yes, you're right! I'll try to look into that when I find some time!