vuepress / vuepress-community

:bulb: Community supported ecosystem for VuePress
https://vuepress-community.netlify.app
MIT License
81 stars 62 forks source link

[Bug Report] missing type defination in vuepress-types #10

Closed Mister-Hope closed 4 years ago

Mister-Hope commented 4 years ago

I turn on noImplicitAny in my tsconfig, and that will cause issue when I want to convert ts file in to js.

node_modules/vuepress-types/types/plugin.d.ts:42:19 - error TS7006: Parameter 'config' implicitly has an 'any' type.

42   chainWebpack?: (config, isServer: boolean) => void
                     ~~~~~~

node_modules/vuepress-types/types/plugin.d.ts:49:20 - error TS7006: Parameter 'config' implicitly has an 'any' type.

49   chainMarkdown?: (config) => void
Mister-Hope commented 4 years ago

I think it's fine to jusst mark them as any, because we don't really expect to get type lint here, instead of leaving them without type defination.

meteorlxy commented 4 years ago

Yes, any is OK here. For now you can disable noImplicitAny as a workaround

Mister-Hope commented 4 years ago

By the way, when will you release the next version, it's been nearly three month, and I have to make a workaround for a bug which is fixed in master.

meteorlxy commented 4 years ago

Most of the team members do not have access to publish npm package of vuepress.

We are waiting for ulivz to release next version, too.

Mister-Hope commented 4 years ago

Got it! 😃

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.