fix(plugin-smooth-scroll): decode hash chars when using document.querySelector - Githubissues

vuepress / vuepress-community

:bulb: Community supported ecosystem for VuePress

https://vuepress-community.netlify.app

MIT License

82 stars 62 forks source link

fix(plugin-smooth-scroll): decode hash chars when using document.querySelector #68

Closed leey0818 closed 3 years ago

leey0818 commented 3 years ago

Summary

Which package does this PR involve? (check one)

[ ] root project
[ ] vuepress-plugin-clean-urls
[ ] vuepress-plugin-container
[ ] vuepress-plugin-dehydrate
[ ] vuepress-plugin-medium-zoom
[ ] vuepress-plugin-named-chunks
[ ] vuepress-plugin-nprogress
[ ] vuepress-plugin-redirect
[x] vuepress-plugin-smooth-scroll
[ ] vuepress-plugin-table-of-contents
[ ] vuepress-plugin-typescript
[ ] vuepress-plugin-zooming
[ ] vuepress-mergeable
[ ] vuepress-types

What kind of change does this PR introduce? (check at least one)

[x] Bugfix (fix)
[ ] Feature (feat)
[ ] Performance enhancement (perf)
[ ] Code Style (style)
[ ] Refactor (refactor)
[ ] Docs (docs)
[ ] Build-related changes (build)
[ ] CI-related changes (ci)
[ ] Testing (test)
[ ] Other, please describe:

Does this PR introduce a breaking change? (check one)

[ ] Yes
[x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

[ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

Other information:

Fixed a not a valid selector error when using non-English characters. Decoded the hash before using document.querySelector.

capture-not-a-valid-selector-with-non-english-chars

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.