Any plans for supporting vuepress-next?

Enigmatrix commented 2 years ago

Feature request

What problem does this feature solve?

There is a similar issue for this but I was wondering if this repo is going to officially support vuepress-next. So far I don't really see any branches or PRs for it yet.

Are you willing to work on this yourself?

Yep, as long as a general direction is given, or atleast there's a branch with some todo list

ulivz commented 2 years ago

// cc @meteorlxy

magicds commented 2 years ago

want support vuepress-next too.

Mister-Hope commented 2 years ago

Hi there, vuepress-plugin-blog2 is compatable with VuePress2 design, and you may use it in vuepress@next projects.

aentwist commented 2 years ago

@Mister-Hope I find it unclear whether that is a blog plugin or a theme, or where the divide is there. It is made worse because the repo and documentation are called vuepress-theme-hope. Can you clarify this? I am looking forward to potentially taking it for a test drive. I am guessing that it is a theme that happens to add v2 support? Once the official blog plugin is split off, will it be decoupled from the theme?

aentwist commented 2 years ago

Is that what you are discussing in vuepress/vuepress-next #54?

I will start rebuilding awesome vuepress project these days to split v1 and v2

once meteorlxy has time, we may split current repo, move this plugin and publish under https://github.com/vuepress as plugin-blog@v2

Is there any way we can help split it out?

I would agree that the vast number of plugins under the theme should be split (if I understand right) for full build control.

Mister-Hope commented 2 years ago

@Mister-Hope I find it unclear whether that is a blog plugin or a theme, or where the divide is there

It is made worse because the repo and documentation are called vuepress-theme-hope.

Can you clarify this? I am looking forward to potentially taking it for a test drive. I am guessing that it is a theme that happens to add v2 support? Once the official blog plugin is split off, will it be decoupled from the theme?

??? No offense, but as we are pointing out the docs:

And the docs https://vuepress-theme-hope.github.io/v2/blog/ says:

It's already providing a detailed docs. And if you have any trouble, you can open issues in its own repos

What's the matter here?

Mister-Hope commented 2 years ago

Also, I am currenly vuepress core team member, and I am fully maintaining vuepress-next github repo with issues and PRs. You should be able to find me at https://github.com/orgs/vuepress/people

I am not finding any differences releasing my plugin in my own org vuepress-theme-hope or in vuepress/community or under vuepress/vuepress-next with @vuepress/ scope.

If you want some garuntees here, then I shall tell you that you can regard me as that. No matter where this plugin is replaced, it will always under my maintainance. 🤪

aentwist commented 2 years ago

No offense taken because I already looked at that. I also already know that you are a core contributor.

I wanted to make sure that when I install blog2 that is all I am getting, and that I am not getting anything else from theme-hope. The reason I ask this is that I see that the blog2 plugin is being housed in a monorepo. I have no issues with the namespace.

On second glance, it appears that this is certainly the case. The npm link points to the repo root, and not the blog2 root. That was the confusion.

If you are looking for help with development I think the people here are interested.

Thanks for the great work, I am looking forward to trying it out!

Mister-Hope commented 2 years ago

Thanks for point out that, it should be fixed now as I am marking the latest next as latest

Enigmatrix commented 2 years ago

Just wanted to ask - why isn't the blog2 plugin in a different repository instead of it's current monorepo status within vuepress-theme-hope? I think the fact that it is under vuepress-theme-hope gives it the idea that the blog2 plugin cannot be used without the theme itself.

Mister-Hope commented 2 years ago

So why don't you have a idea that @vuepress/plugin-git can only be used with @vuepress/theme-default? vuepress/vuepress-next is also a monorepo.

vuepress-plugin-blog2 have sperate docs, and it's released as a sperate package, and it's not under @mr-hope scope or @vuepress-theme-hope scope (e.g.: @vuepress-theme-hope/vuepress-plugin-blog. Why came the idea?

🧐I can migrate vuepress-theme-hope repo under vuepress/vuepress-theme-hope at any time. But I don't think that's needed.

monorepo is much more easier to maintain, as config can be shared and packages can require each other.

Also:

a package called @mr-hope/vuepress-shared is shared among these packages, make it hard to maintain. Also, some plugin may require each other. So releasing new versions could be nightmare as:
```
@mr-hope/vuepress-shared → vuepress-plugin-reading-time2 → @mr-hope/vuepress-plugin-components → vuepress-theme-hope
                          ↘        ... and other plugins                                          ↗
```
Also, that's why all plugins of @vuepress/theme-default are in vuepress/vuepress-next repo.
If these packages are splited, then linter, bundler and other config can not be shared across these packages, leaving a lot of same files across repos and hard to maintain
All plugin docs is using vuepress-theme-hope, but the theme is requiring these plugins, so that an older version deps may be installed in the package repo. That's PRETTY weird and HARD to maintain,

So, just to be clear, there is not any chance to split the repo by my side.

Mister-Hope commented 2 years ago

Also, vuepress-theme-hope may released as @vuepress/theme-plus @vuepress/theme-pro or maybe even @vuepress/theme-default after removing some default bundled features, meteorlxy is busy, and we will dicuss that when he has time. He is leaving current job and I am a postgraduate student facing block down caused by covid 19, so we are all busy in real life at this time.

vuepress / vuepress-plugin-blog