What kind of change does this PR introduce? (check at least one)
[x] Bugfix
[ ] Feature
[ ] Code style update
[ ] Refactor
[ ] Docs
[ ] Build-related changes
[ ] Other, please describe:
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
[ ] Yes
[x] No
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
[] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
You have tested in the following browsers: (Providing a detailed version will be better.)
[x] Chrome
[ ] Firefox
[ ] Safari
[ ] Edge
[ ] IE
If adding a new feature, the PR's description includes:
[ ] A convincing reason for adding this feature
[ ] Related documents have been updated
[ ] Related tests have been updated
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
The summary provided can contain a broken markdown.
We faced this issue on https://theheadless.dev when the summary were trimmed based on the configured characters, there were scenarios where the markdow was not valid anymore (please check the image attached).
This PR changes the logic to remove the markdown of the summary first and then slice the content. We introduce the same fix in our config and works as expected.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: The summary provided can contain a broken markdown.
We faced this issue on https://theheadless.dev when the summary were trimmed based on the configured characters, there were scenarios where the markdow was not valid anymore (please check the image attached).
This PR changes the logic to remove the markdown of the summary first and then slice the content. We introduce the same fix in our config and works as expected.
More info https://github.com/vuejs/vuepress/issues/2657 https://github.com/checkly/theheadless.dev/pull/84