vuepress / vuepress-theme-blog

Default blog theme for VuePress.
https://vuepress-theme-blog.billyyyyy3320.com/
MIT License
211 stars 129 forks source link

fix: empty links directed to '/.html' (fix #105) #110

Closed lirc572 closed 3 years ago

lirc572 commented 3 years ago

Summary

fixes #105

NavLink component now routes to '' if link prop is empty or only contains whitespaces (no redirection).

Now, clicking on copyright section in the footer does not cause redirection to '/.html'.

What kind of change does this PR introduce? (check at least one)

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

You have tested in the following browsers: (Providing a detailed version will be better.)

If adding a new feature, the PR's description includes:

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

billyyyyy3320 commented 3 years ago

Opened #111

lirc572 commented 3 years ago

Thanks! Plain-text copyright info looks nice!

Although this is not important, I still think it is erroneous for NavLink to append '.html' to an empty path. Maybe an empty link can serve as a placeholder?