Closed lirc572 closed 3 years ago
Opened #111
Thanks! Plain-text copyright info looks nice!
Although this is not important, I still think it is erroneous for NavLink
to append '.html' to an empty path. Maybe an empty link can serve as a placeholder?
Summary
fixes #105
NavLink component now routes to
''
iflink
prop is empty or only contains whitespaces (no redirection).Now, clicking on copyright section in the footer does not cause redirection to '/.html'.
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: