vuepress / vuepress-theme-blog

Default blog theme for VuePress.
https://vuepress-theme-blog.billyyyyy3320.com/
MIT License
211 stars 129 forks source link

Custom Containers Not Working #70

Closed RehanSaeed closed 4 years ago

RehanSaeed commented 4 years ago

Bug report

Vuepress supports custom containers but these don't seem to work with this theme.

image

Steps to reproduce

Enter the following markdown:

::: tip
This is a tip
:::

What is expected?

I should see the custom container.

What is actually happening?

I just get the text being output as is.

Environment Info:

  System:
    OS: Windows 10 10.0.19569
    CPU: (8) x64 Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz
  Binaries:
    Node: 13.9.0 - C:\Program Files\nodejs\node.EXE
    Yarn: Not Found
    npm: 6.13.7 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: 44.19569.1000.0
  npmPackages:
    @vuepress/core: Not Found
    @vuepress/theme-default: Not Found
    vuepress: ^1.3.1 => 1.3.1
  npmGlobalPackages:
    vuepress: Not Found
billyyyyy3320 commented 4 years ago

Duplicate of #20. Take a look at vuepress-plugin-container.

RehanSaeed commented 4 years ago

Could it not be included? Since the default theme had it, I'd expect the blog theme to be a superset of the default theme.

billyyyyy3320 commented 4 years ago

Expect it to be something like:

VuePress 
 ├── Default theme       
 ├── Blog theme        
 └── ...Other themes   

# Instead of:

VuePress 
 └── Default theme       
     ├── Blog theme        
     └── ...Other themes   

Container is not a necessary (widely used) feature for blogging. As the plugin system came out, we can leave such feature to users.