Fix mobile menu not closing and isMobile state not always being correct

nentor commented 2 years ago

Description

This PR fixes a bug where the mobile menu wouldn't close upon route transition. It also fixes a bug where the "isMobile" state of the AppHeader component was not always correct. With this, I have also formatted the corresponding files.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

samberrry commented 2 years ago

Hi @nentor, thanks for your contribution. As your fix relates to the vue-storefront@nuxt-theme, can you please apply it on the core repo: https://github.com/vuestorefront/vue-storefront

It's preferable to have it (if VSF team find it a good improvement) as an update on core repo, this way we can better maintain our PrestaShop integration project.

Also, if you are interested in to contribute to the integration you can ping me on Discord channel: https://discord.vuestorefront.io/ in prestashop section to coordinate things. Thanks.

nentor commented 2 years ago

@samberrry Only the change within the AppHeader file seems to be related to the core code. They don't seem to have the other one for the header navigation or it could be structured differently there.

samberrry commented 2 years ago

@samberrry Only the change within the AppHeader file seems to be related to the core code. They don't seem to have the other one for the header navigation or it could be structured differently there.

I see that the changes relate to nuxt-theme, so they can be re-structured there.

About PrestaShop integration, it's preferable to keep the theme files' version the same as vue-storefront@nuxt-theme as much as possible.

vuestorefront-community / prestashop