perf: updated SFUI version to 0.12.0

vuestorefront-community / vendure

Vue Storefront 2 integration for Vendure

https://docs.vuestorefront.io/vendure/

MIT License

72 stars 51 forks source link

perf: updated SFUI version to 0.12.0 #179

Closed disha1202 closed 2 years ago

disha1202 commented 2 years ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

disha1202 commented 2 years ago

Great work +1 . Could you please also remove sidebar-top in wishlist sidebar (on mobile version). It should appear only on the desktop.

Sure, I'll look around it as well :)

Baroshem commented 2 years ago

Hey @disha1202

Could you please add the recommendations from @AdamPawlinski ? :)

disha1202 commented 2 years ago

Hey @disha1202

Could you please add the recommendations from @AdamPawlinski ? :)

Made the requested changes :)

disha1202 commented 2 years ago

Also, I was trying to resolve merge conflicts but when I commit I keep getting this error Screenshot from 2022-03-24 21-38-41 Can you please help me out?

AdamPawlinski commented 2 years ago

@disha1202 I think, for now you can pass it with no-verify command:

git commit --no-verify

disha1202 commented 2 years ago

@disha1202 I think, for now you can pass it with no-verify command:
git commit --no-verify

Okay, Thanks.

Baroshem commented 2 years ago

Hey @disha1202

Sorry for no contact for a long time. Had other stuff to do and could not focus on the integration development. I decided to cancel this PR as the newer versions of Storefront UI introduced several breaking changes that will cause issue for the current users of the integration. Also, since then, the newer version of Storefront UI was released (0.13.0) so I will create a PR soon with the migration to the newest version.

Thank you for your work!