fix: placeholder image height on the collections page

vuestorefront-community / vendure

Vue Storefront 2 integration for Vendure

https://docs.vuestorefront.io/vendure/

MIT License

72 stars 51 forks source link

fix: placeholder image height on the collections page #186

Closed ymaheshwari1 closed 2 years ago

ymaheshwari1 commented 2 years ago

Description

Added height for the placeholder component

Related Issue

closes #181

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Baroshem commented 2 years ago

Hey @ymaheshwari1

Sorry for keep you waiting. I was bit busy with other tasks.

I dont think that this will solve the issue becuase the bug was reported as an issue in the javascript, not the styles.

ymaheshwari1 commented 2 years ago

Hey @ymaheshwari1

Sorry for keep you waiting. I was bit busy with other tasks.

I dont think that this will solve the issue becuase the bug was reported as an issue in the javascript, not the styles.

Hi @Baroshem Actually the placeholder image gets loaded always but the issue is that the height of the image is so small that's it is not properly visible.

Baroshem commented 2 years ago

@ymaheshwari1

But the problem is that we expect that the product will contain image, while in some cases you may not have an image. So in here, an optional chaining should be added in order to avoid bugs such as the one reported by the issue reporter

Baroshem commented 2 years ago

Decided to close this PR as it does not solve the issue. I will work on it and develop a different fix instead.