search

vuestorefront-community / vendure

Vue Storefront 2 integration for Vendure
https://docs.vuestorefront.io/vendure/
MIT License
72 stars 51 forks source link

[Bug]: MyReviews.vue page has null content #191

Closed ekwoue closed 2 years ago

ekwoue commented 2 years ago

Expected Behavior

No response

Actual Behavior

When I initiate a storefront project with vendure, the MyReviews.vue page has empty content.

Here is the generated project: https://github.com/ekwoue/storefront-vendure The page that's empty: https://github.com/ekwoue/storefront-vendure/blob/master/pages/MyAccount/MyReviews.vue

I tried on another workstation under Windows 11 and Node 13.14.0 and I had the same problem.

Does MyReviews.vue page need to be generated?

Possible Solution

No response

Steps to reproduce

No response

What version of vendure integration are you using?

1.5.0

What version of Node.js are you using?

14.19.0

What browser (and version) are you using?

Chrome

What operating system (and version) are you using?

Windows 11

Relevant log output

No response

Code of Conduct

Baroshem commented 2 years ago

Hey @ekwoue

Thanks for reporting that. This is kind of a strange issue TBH. I will investigate it in the upcoming days.

Baroshem commented 2 years ago

After second thought, Vendure does not have a reviews plugin implemented yet, so maybe this is the issue. We might have at some point removed this page as there is no support for reviews yet

michaelbromley commented 2 years ago

Yeah, Vendure has no built-in reviews support.

Baroshem commented 2 years ago

@ekwoue

I know what is the problem. For some strange reason, the MyReviews.vue is a binary file in the template-vendure. I will remove it as Vendure does not have Reviews so we wont be able to cover it in VSF.

Baroshem commented 2 years ago

Will be released with a new 1.2.0 version -> https://github.com/vuestorefront-community/template-vendure/pull/11

Baroshem commented 2 years ago

Closing the issue as this bugfix was merged and released with 1.2.0