vuestorefront-community / vendure

Vue Storefront 2 integration for Vendure
https://docs.vuestorefront.io/vendure/
MIT License
72 stars 51 forks source link

[Bug]: email verification not working #197

Closed macrozone closed 2 years ago

macrozone commented 2 years ago

Expected Behavior

email verification link should work and verify the email

Actual Behavior

the email gets sent out, but the link does not work:

Page not found We are sorry that we can’t find the page, please go back or try again

the link is https://someurl.com/verify?token=sometoken

Possible Solution

should be a minor thing to add this one route

Steps to reproduce

No response

What version of vendure integration are you using?

1.1.0

What version of Node.js are you using?

12.x

What browser (and version) are you using?

chrome

What operating system (and version) are you using?

macos

Relevant log output

No response

Code of Conduct

Baroshem commented 2 years ago

Hey @macrozone

Are you sure that this is a frontend issue? Seems more like Vendure to me. Also VSF by default does not support email verification.

Maybe @michaelbromley could help as well.

macrozone commented 2 years ago

@Baroshem it is definitly a frontend problem, because the verification email sends the user to a certain route on the frontend: https://someurl.com/verify?token=sometoken

the frontend should honor this route and call the corresponding api (depending on the shop-backend) and show some message or redirect the user somewhere.

michaelbromley commented 2 years ago

I think it's just not implemented in the VSF integration yet.

Indeed, this is explicitly stated in the docs: image

So I think this is more of a feature request on supporting the verification flow.

@Baroshem is there any example of another VSF integration which does implement a verification flow? Any idea what it would take to implement support for Vendure?

Baroshem commented 2 years ago

No, it is not implemented in VSF. VSF by default does not support verification by email. Don't think there is a roadmap point to include that in core VSF so you would have to develop it in your own project.

Baroshem commented 2 years ago

Closing this as it is out of the scope of VSF functionality.