search

vuestorefront / magento2-vsbridge-indexer

This is official Vue Storefront, native, Magento2 indexer
https://vuestorefront.io
MIT License
69 stars 89 forks source link

Indexer reset command name overrides Magento indexer:reset command #324

Closed jambardnishvili closed 4 years ago

jambardnishvili commented 4 years ago

Magento 2.3.3 Installation

Currently, Magento 2 indexer:reset command is not showing up during bin/magento execution, from some digging in code found that one of the vsbridge commands include the same name as indexer:reset command in di.xml and this prevents it from displaying the Magento command

File location src/module-vsbridge-indexer-core/etc/di.xml

temporary solution change command name to something else

<item name="reset > reset_vsbridge" xsi:type="object">Divante\VsbridgeIndexerCore\Console\Command\ResetEsIndexCommand</item>
nagrgkgc commented 4 years ago

@Vandeveon this can be renamed.

renaming would work? if yes, we can commit change for this

jambardnishvili commented 4 years ago

@nagrgkgc Yes after renaming indexer:reset command appeared again

afirlejczyk commented 4 years ago

Yes, we shouldn't override magento native commands. I will update the name. Fixed available in version: 1.19.1 and 1.20.1