search

vuestorefront / shopify

Vue Storefront 2 integration for Shopify
https://docs.vuestorefront.io/shopify
MIT License
150 stars 84 forks source link

[Bug]: hardly any completed TypeScript types #372

Open tafelnl opened 2 years ago

tafelnl commented 2 years ago

Expected Behavior

For this to be production ready I think it's fair to have at least the essential types like UserAddress, Product etc. implemented. Right now they are useless as they are all defined as unknown. As can be seen here: https://github.com/vuestorefront/shopify/blob/bc888047935e5979d3d1876bad965e5f3c2cb84c/packages/composables/src/types/index.ts

This makes it impossible to use @vue-storefront/shopify in a TypeScript environment. Which is a pity. A respectable storefront implemented in JavaScript should be type-safe in my opinion.

Are there any plans to tackle this?

Actual Behavior

No types present.

Possible Solution

Implement the correct types.

Steps to reproduce

No response

What version of shopify integration are you using?

1.1.2

What version of Node.js are you using?

v16

What browser (and version) are you using?

n/a

What operating system (and version) are you using?

n/a

Relevant log output

No response

Code of Conduct