vuestorefront / storefront-api

Storefront GraphQL API Gateway. Modular architecture. ElasticSearch included. Works great with Magento1, Magento2, Spree, OpenCart, Pimcore and custom backends
https://storefrontapi.com
MIT License
8 stars 1 forks source link

Feature/refactor code to typescript #24

Closed ResuBaka closed 4 years ago

ResuBaka commented 4 years ago

Related issues

closes #22

Short description and why it's useful

Screenshots of visual changes before/after (if there are any)

IMPORTANT NOTICE - Remember to update CHANGELOG.md with a description of your change

Contribution and currently important rules acceptance

ResuBaka commented 4 years ago

I still want to change more code to typescript and add better type hinting.

But when you guys want this in the source code asap I can move it to Ready for review.

pkarw commented 4 years ago

@ResuBaka take your time, that's perfect

ResuBaka commented 4 years ago

It is now ready to review and we should have one that makes a QA on it so we still now that all works like we expect.

We need a followup for the logger class that we add the missing documentation and @pkarw can you look if it is usable or if there are missing helper/functions for it?