vuestorefront / storefront-api

Storefront GraphQL API Gateway. Modular architecture. ElasticSearch included. Works great with Magento1, Magento2, Spree, OpenCart, Pimcore and custom backends
https://storefrontapi.com
MIT License
8 stars 1 forks source link

Feature/move logic to packages #30

Closed ResuBaka closed 4 years ago

ResuBaka commented 4 years ago

Related issues

closes #

Short description and why it's useful

Move core code to its own packages that can be released. This is done to clean up the imports and to in a later stage move to an template repository, so that you don't need to clone the core code into your project.

Thinks that still needs to be done are:

Screenshots of visual changes before/after (if there are any)

IMPORTANT NOTICE - Remember to update CHANGELOG.md with a description of your change

Contribution and currently important rules acceptance

ResuBaka commented 4 years ago

I have done a small change in the image api logic that needs to be tested. There I have removed the .crop() as it not there any more. So there we would need to have some one look over.

ResuBaka commented 4 years ago

The fix option for image now work as before.

But I have found one problem that I need to fix before this can be merged.

When you run yarn build:packages you need to clear it or ts-node should not load the *.d.ts files. That is something I now try to fix.