search

vuestorefront / storefront-api

Storefront GraphQL API Gateway. Modular architecture. ElasticSearch included. Works great with Magento1, Magento2, Spree, OpenCart, Pimcore and custom backends
https://storefrontapi.com
MIT License
8 stars 1 forks source link

Error with winston #85

Closed tdugue closed 4 years ago

tdugue commented 4 years ago

Hi @pkarw,

When you run the yarn o2m command there is an error with winston.

Version 3.2 is used and since version 3.0 they removed logger.emitErrs = false; ( https://github.com/winstonjs/winston/issues/1200#issuecomment-362183316 )

They also changed the way to instantiate the logger and format I updated the code to be compatible with version 3.2.

Related issues

closes #

Short description and why it's useful

Screenshots of visual changes before/after (if there are any)

IMPORTANT NOTICE - Remember to update CHANGELOG.md with a description of your change

Contribution and currently important rules acceptance

ryantfowler commented 4 years ago

@tdugue Unfortunately, there's a whole host of changes on the develop branch, which haven't been marked as a proper release yet. As a result, there's changes like what your PR addresses, which have already been made. For instance, if you look here you'll see that the log.ts file has been removed entirely.

Hopefully this helps you.

tdugue commented 4 years ago

@ryantfowler thank you for your feedback I wanted to base myself on RC but maybe I will switch to develop.

Thanks