search

vuestorefront / storefront-query-builder

ElasticSearch Query builder from the abstract "SearchQuery" object used by storefront-api, vue-storefront-api and vue-storefront projects
MIT License
7 stars 21 forks source link

searchScoring config values not applied #13

Closed undefinederror closed 4 years ago

undefinederror commented 4 years ago

I was trying to change ES query properties like an idiot from config and seeing them not applied at all, when I found this

https://github.com/DivanteLtd/storefront-query-builder/blob/master/src/elasticsearch/score.ts

image

boost_mode, score_mode, max_boost, min_score are sough on config root while they are on config.elasticsearch.searchScoring.

Is this intended or just an oversight? If not intended can I submit a PR?