vuestorefront / storefront-ui

A frontend library for Vue and React that helps developers quickly build fast, accessible, and beautiful storefronts. Made with 💚 by Vue Storefront team and contributors.
https://storefrontui.io
MIT License
2.33k stars 455 forks source link

[BUG] Storybook Organisms BottomNavigation props options do not work #2485

Closed MaciejWolowski closed 1 year ago

MaciejWolowski commented 2 years ago

Describe the bug All the options to customise bottomnavigation in the storybook do not work.

How to reproduce Steps to reproduce the behavior:

  1. Go to storybook
  2. open section components -> organisms -> BottomNavigation
  3. Try to customise component using props on the bottom

Expected behavior Options selected do not work and changes nothing in the component.

Actual behavior You can customise component with options provided.

Screenshots Storybook Organisms BottomNavigation props options do not work

Devices (please complete the following information):

┆Issue is synchronized with this Jira Task by Unito

justyna-13 commented 1 year ago

There are listed props for internal components but they aren't connected with a component. It's just as additional information what props will be needed. I can add a shot note that changes in these fields won't affect data in this component :) what do you think about it?

MaciejWolowski commented 1 year ago

Good idea

pon., 31 paź 2022, 14:05 użytkownik Justyna @.***> napisał:

There are listed props for internal components but they aren't connected with a component. It's just as additional information what props will be needed. I can add a shot note that changes in these fields won't affect data in this component :) what do you think about it?

— Reply to this email directly, view it on GitHub https://github.com/vuestorefront/storefront-ui/issues/2485#issuecomment-1297060129, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYTZ7CNMCLFL3XDT3Q3KRXLWF672XANCNFSM6AAAAAAQARFVTY . You are receiving this because you authored the thread.Message ID: @.***>

AdamPawlinski commented 1 year ago

I'm closing this ticket as it doesn't meet the requirements of LTS policy..