search

vuestorefront / vsf-capybara

Capybara is a Storefront UI based theme for Vue Storefront. Always Open Source, MIT license. Made with :green_heart: by Vue Storefront.
https://capybara.storefrontcloud.io/
MIT License
154 stars 84 forks source link

Updated: the code to render the images properly when using the mergeConfigurableChildren to false (#551) #552

Closed ymaheshwari1 closed 3 years ago

ymaheshwari1 commented 3 years ago

Related Issues

551

Closes #551

Short Description and Why It's Useful

This will help in rendering the images as expected when setting the mergeConfigruableChildren to false. Using another SfGallery for mergeconfigruableChildren as to re-render the gallery using the key value which is set to currentIndex.

Screenshots of Visual Changes before/after (If There Are Any)

Before: image

After: image

IMPORTANT NOTICE - Remember to update CHANGELOG.md with description of your change

Contribution and Currently Important Rules Acceptance

ymaheshwari1 commented 3 years ago

Many thanks to @dt2patel for the suggestion, which help in solving the issue with very little change.

Fifciu commented 3 years ago

What would happen if gallery.length does not change between colors?

ymaheshwari1 commented 3 years ago

What would happen if gallery.length does not change between colors?

When gallery length is not changing then there is no issue in the product gallery, the gallery renders completely fine, the issue comes whenever the gallery length changes between either the product or when changing color.

ymaheshwari1 commented 3 years ago

@Fifciu, I updated the PR, please have a look.

ymaheshwari1 commented 3 years ago

Maintained the changelog for the PR here: https://github.com/vuestorefront/vsf-capybara/pull/573