check if 'custom_design_from' should be removed

vuestorefront / vue-storefront-1

The open-source frontend for any eCommerce. Built with a PWA and headless approach, using a modern JS stack. We have custom integrations with Magento, commercetools, Shopware and Shopify and total coverage is just a matter of time. The API approach also allows you to merge VSF with any third-party tool like CMS, payment gateways or analytics. Newest updates: https://blog.vuestorefront.io. Always Open Source, MIT license.

https://www.vuestorefront.io

MIT License

19 stars 13 forks source link

check if 'custom_design_from' should be removed #189

Closed bloodf closed 3 years ago

bloodf commented 3 years ago

From vue-storefront created by pschaub: vuestorefront/vue-storefront#5190

I have seen that there is a category has an API field named custom_design_from.

Why is it still there but never used? Should we remove it?

see: https://github.com/DivanteLtd/vue-storefront/search?q=custom_design_from

Edit: there is also a custom_design_to field.

bloodf commented 3 years ago

I have seen that there is a feature in Magento to define a date range for a custom design. But is it then correct to have this in the default configuration file, even if you don't use Magento?