shouldUpdateClientState in sync action should be configurable - Githubissues

vuestorefront / vue-storefront-1

The open-source frontend for any eCommerce. Built with a PWA and headless approach, using a modern JS stack. We have custom integrations with Magento, commercetools, Shopware and Shopify and total coverage is just a matter of time. The API approach also allows you to merge VSF with any third-party tool like CMS, payment gateways or analytics. Newest updates: https://blog.vuestorefront.io. Always Open Source, MIT license.

https://www.vuestorefront.io

MIT License

18 stars 13 forks source link

shouldUpdateClientState in sync action should be configurable #205

Closed bloodf closed 3 years ago

bloodf commented 3 years ago

From vue-storefront created by janmarkuslanger: vuestorefront/vue-storefront#5345

What is the motivation for adding / enhancing this feature?

The behavior here https://github.com/vuestorefront/vue-storefront/blob/master/core/modules/cart/store/actions/synchronizeActions.ts#L51 should be configurable.

Current behavior:

Log in
Add item to cart (e.g. T-Shirt)
Log out
My cart is now empty and saved to my account
If I log in, then my cart restores, and I have my T-shirt
Now I am putting another product in the cart (e.g., Shoes)
Go to checkout
Login during checkout
Shoes are in my cart
My T-Shirt product is gone

The behavior that my client state will update when I am in my checkout should be configurable (e.g. forceUpdateStateClientInCheckout):

Log in
Add item to cart (e.g. T-Shirt)
Log out
My cart is now empty and saved to my account
If I log in, then my cart restores, and I have my T-shirt
Now I am putting another product in the cart (e.g., Shoes)
Go to checkout
Login during checkout

If forceUpdateStateClientInCheckout:

Shoes are in my cart
My T-Shirt product is gone

Else:

Shoes and T-Shirt are both in my cart

What are the acceptance criteria

By default shouldUpdateClientState should be true
If forceUpdateStateClientInCheckout is true it should update client state
If forceUpdateStateClientInCheckout is false it should not update client state

Version of Vue Storefront

[x] Vue Storefront
[ ] Vue Storefront Next

Can you complete this feature request by yourself?

[x] YES
[ ] NO

Let me know what you think. :)

Greets, Jan