search

vuestorefront / vue-storefront-1

The open-source frontend for any eCommerce. Built with a PWA and headless approach, using a modern JS stack. We have custom integrations with Magento, commercetools, Shopware and Shopify and total coverage is just a matter of time. The API approach also allows you to merge VSF with any third-party tool like CMS, payment gateways or analytics. Newest updates: https://blog.vuestorefront.io. Always Open Source, MIT license.
https://www.vuestorefront.io
MIT License
19 stars 13 forks source link

Order id again is not assigned in the orders.directBackendSync mode #210

Closed bloodf closed 3 years ago

bloodf commented 3 years ago

From vue-storefront created by Cheeerd: vuestorefront/vue-storefront#5433

In past it was fixed with this commit: https://github.com/vuestorefront/vue-storefront/commit/23d6edcdd76e827028bdc5aca751c8fcd591a7c0

But in current version order id is being added to order variable that will no longer being used, and there are the "optimizedOrder" variable is used instead: https://github.com/vuestorefront/vue-storefront/blob/d6f7afd1b5dc4da99e2ade8cd8aa792c324dc420/core/modules/order/store/actions.ts#L30

As a result, the order again ends up without order id which shows up in the vue-storefront-api logs (Order Id undefined): image

It can be fixed by changing line commit(types.ORDER_ADD_SESSION_STAMPS, newOrder) to commit(types.ORDER_ADD_SESSION_STAMPS, optimizedOrder)