404 don't respect redirect in multistore mode when CMS page not founded - Githubissues

vuestorefront / vue-storefront-1

The open-source frontend for any eCommerce. Built with a PWA and headless approach, using a modern JS stack. We have custom integrations with Magento, commercetools, Shopware and Shopify and total coverage is just a matter of time. The API approach also allows you to merge VSF with any third-party tool like CMS, payment gateways or analytics. Newest updates: https://blog.vuestorefront.io. Always Open Source, MIT license.

https://www.vuestorefront.io

MIT License

18 stars 13 forks source link

404 don't respect redirect in multistore mode when CMS page not founded #234

Closed bloodf closed 3 years ago

bloodf commented 3 years ago

From vue-storefront created by fatimazohranasri: vuestorefront/vue-storefront#5782

Current behavior

When CMS page is not found, store on url is not supported when redirecting to page not found

Expected behavior

when set an url to CMS page not founded, the redirection change the actual store to the default store plus not-found-page

Steps to reproduce the issue

You need fresh install of app, with stable version, default theme.
You need change settings/config file: set storeViews.multistore to true and add the your stores to mapStoreUrlsFor` (like "mapStoreUrlsFor": ["de","fr","it"]).
Run app in browser
set an url of a cms page that does not exist (like : /i/not-exesting-page)

Version of Vue Storefront

[x] Vue Storefront
[ ] Vue Storefront Next

Can you handle fixing this bug by yourself?

[ ] YES
[x] NO

Which Release Cycle state this refers to? Info for developer. (doesn't apply to Next)

Pick one option.

[ ] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[ ] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[x] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

Environment details

Browser:
OS:
Node:
Code Version:

Additional information