vuestorefront / vue-storefront-1

The open-source frontend for any eCommerce. Built with a PWA and headless approach, using a modern JS stack. We have custom integrations with Magento, commercetools, Shopware and Shopify and total coverage is just a matter of time. The API approach also allows you to merge VSF with any third-party tool like CMS, payment gateways or analytics. Newest updates: https://blog.vuestorefront.io. Always Open Source, MIT license.
https://www.vuestorefront.io
MIT License
18 stars 13 forks source link

Cannot add 3rd party plugins to theme #241

Closed bloodf closed 3 years ago

bloodf commented 3 years ago

From vue-storefront created by mateuszrusiecki: vuestorefront/vue-storefront#6004

Current behavior

According to the documentation to import 3rd party plugins I have to register it in /src/themes/default/plugins/index.js , which I have tried to do

import firebaseui from 'firebaseui';

and I get error:

ERROR in ./src/themes/default/index.js
Module not found: Error: Can't resolve 'firebaseui' in '/var/www/src/themes/default'

Expected behavior

the plugin should be registered

Steps to reproduce the issue

install firebase plugin and add the above code

Version of Vue Storefront

Can you handle fixing this bug by yourself?

Environment details

Additional information

It happens also for other 3rd party plugins

bloodf commented 3 years ago

bump

bloodf commented 3 years ago

Try to add firebaseui to theme's package.json and then run yarn from the root directory.

bloodf commented 3 years ago

bump

bloodf commented 3 years ago

the issue is that: when I go to src/themes/default and do yarn add firebaseui it adds it to package.json, but when I do yarn install it's not creating node_modules in src/themes/default o_O yarn --cwd src/themes/defaul install also not creates node_modules How I should install those dependencies then? I need to manage workspaces somehow? I have yarn 1.22, maybe I should use yarn 2? I can use npm fot that and then it works but would be better to use yarn it whole project