Add unit tests for `core/modules/catalog`

vuestorefront / vue-storefront-1

The open-source frontend for any eCommerce. Built with a PWA and headless approach, using a modern JS stack. We have custom integrations with Magento, commercetools, Shopware and Shopify and total coverage is just a matter of time. The API approach also allows you to merge VSF with any third-party tool like CMS, payment gateways or analytics. Newest updates: https://blog.vuestorefront.io. Always Open Source, MIT license.

https://www.vuestorefront.io

MIT License

19 stars 13 forks source link

Add unit tests for `core/modules/catalog` #304

Open pkarw opened 5 years ago

pkarw commented 5 years ago

What is the motivation for adding/enhancing this feature?

Add unit tests for the module. Reference/example:

What are the acceptance criteria

[ ] all the actions should be tested
[ ] all the helpers should be tested
[ ] all the mutations should be tested

lukeromanowicz commented 5 years ago

@pkarw not sure if there is much point in writing tests for the old catalog. It's a legacy module anyway.

pkarw commented 5 years ago

It’s still being used by Product.vue page and nothing shows it’s going to disappear in foreseeable future :)