search

vuestorefront / vue-storefront-1

The open-source frontend for any eCommerce. Built with a PWA and headless approach, using a modern JS stack. We have custom integrations with Magento, commercetools, Shopware and Shopify and total coverage is just a matter of time. The API approach also allows you to merge VSF with any third-party tool like CMS, payment gateways or analytics. Newest updates: https://blog.vuestorefront.io. Always Open Source, MIT license.
https://www.vuestorefront.io
MIT License
19 stars 13 forks source link

Add vs-api endpoint for indexing the products #33

Closed bloodf closed 3 years ago

bloodf commented 3 years ago

From vue-storefront created by pkarw: vuestorefront/vue-storefront#2486

What is the motivation for adding / enhancing this feature?

Currently vue-storefront-api is accessing ElasticSearch just in read-only mode. The src/api/catalog.js is not accepting any other endpoints than _search. This is good approach regarding the security, however with new magento2-vsbridge-indexer and magento1-vsbrdige-indexer users must connect these modules directly to Elastic without the vs-api in the middle. It won't work with cloud deployments (like storefrontcloud.io) where there is no public access to Elasticsearch instance.

We should extend the catalog.js:

Details: https://github.com/DivanteLtd/magento2-vsbridge-indexer/blob/master/src/module-vsbridge-indexer-core/Elasticsearch/Client.php

What are the acceptance criteria

bloodf commented 3 years ago

In my opinion, we should create new microservice that will be a connection interface to ES. Then we will be able to secure connections by IP checking etc.