The open-source frontend for any eCommerce. Built with a PWA and headless approach, using a modern JS stack. We have custom integrations with Magento, commercetools, Shopware and Shopify and total coverage is just a matter of time. The API approach also allows you to merge VSF with any third-party tool like CMS, payment gateways or analytics. Newest updates: https://blog.vuestorefront.io. Always Open Source, MIT license.
When selecting gallery.mergeConfigurableChildren = false the images are created by attributeImages() in core\modules\catalog\helpers\index.ts
This doesnt filter out "no_selection" images but just adds all images definied in gallery.imageAttributes
Expected behavior
before pushing new image in gallery we shoudl check if image exists:
if (product[attribute] && product[attribute] !== 'no_selection')
Steps to reproduce the issue
Version of Vue Storefront
[x] Vue Storefront
[ ] Vue Storefront Next
Can you handle fixing this bug by yourself?
[x] YES
[ ] NO
Which Release Cycle state this refers to? Info for developer. (doesn't apply to Next)
Pick one option.
[x] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[x] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[x] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.
simonmaass
commented
4 years ago
Current behavior
When selecting gallery.mergeConfigurableChildren = false the images are created by
attributeImages()incore\modules\catalog\helpers\index.tsThis doesnt filter out "no_selection" images but just adds all images definied in gallery.imageAttributes
Expected behavior
before pushing new image in gallery we shoudl check if image exists:
if (product[attribute] && product[attribute] !== 'no_selection')Steps to reproduce the issue
Version of Vue Storefront
Can you handle fixing this bug by yourself?
Which Release Cycle state this refers to? Info for developer. (doesn't apply to Next)
Pick one option.
developbranch and create Pull Request2. Feature / Improvementback todevelop.releasebranch and create Pull Request3. Stabilisation fixback torelease.hotfixormasterbranch and create Pull Request4. Hotfixback tohotfix.Environment details
Additional information
i will create PR