vuestorefront / vue-storefront-1

The open-source frontend for any eCommerce. Built with a PWA and headless approach, using a modern JS stack. We have custom integrations with Magento, commercetools, Shopware and Shopify and total coverage is just a matter of time. The API approach also allows you to merge VSF with any third-party tool like CMS, payment gateways or analytics. Newest updates: https://blog.vuestorefront.io. Always Open Source, MIT license.
https://www.vuestorefront.io
MIT License
19 stars 13 forks source link

Improved: code to use defined method instead of writing same code again(#456) #489

Closed ymaheshwari1 closed 2 years ago

ymaheshwari1 commented 3 years ago

Related Issues

Using the same logic again to check for default_billing

closes #456

Short Description of the PR

Used the predefined method instead of writing the conditions again

Screenshots of Visual Changes before/after (if There Are Any)

Pull Request Checklist

Upgrade Notes and Changelog

Contribution and Currently Important Rules Acceptance

ymaheshwari1 commented 3 years ago

@Fifciu Please review

ymaheshwari1 commented 2 years ago

Good idea, thanks. Please solve the conflict in the changelog

Resolved conflicts @Fifciu

ymaheshwari1 commented 2 years ago

I see unit tests are not passing. Could you please fix them @ymaheshwari1 ?

Sure

ymaheshwari1 commented 2 years ago

I see unit tests are not passing. Could you please fix them @ymaheshwari1 ?

Hi @Fifciu Fixed the failing unit tests, please review

Fifciu commented 2 years ago

Great job @ymaheshwari1 , thank you a lot!