vuestorefront / vue-storefront-1

The open-source frontend for any eCommerce. Built with a PWA and headless approach, using a modern JS stack. We have custom integrations with Magento, commercetools, Shopware and Shopify and total coverage is just a matter of time. The API approach also allows you to merge VSF with any third-party tool like CMS, payment gateways or analytics. Newest updates: https://blog.vuestorefront.io. Always Open Source, MIT license.
https://www.vuestorefront.io
MIT License
18 stars 13 forks source link

[Bug]: change Not Found page layout #500

Open SaraMohElsanan opened 2 years ago

SaraMohElsanan commented 2 years ago

Describe the Bug

I have an Issue when I tried to change the layout of "page-not-found" from default to minimal , cause I don't need any requests to happen in this page , then in the product page or the category page (every other page but static pages with predefined urls) I got an empty header and errors about missing objects from dispatching vuex { name: 'page-not-found', path: '*', component: ErrorPage, meta: { layout: 'minimal' } },

Current behavior

that means * is the default component for every page till the url mapping is done then switch it to the right component , Am I right ?

Expected behavior

Dynamicly created route shouldn't inherit from { name: 'page-not-found', path: '*', component: ErrorPage, meta: { layout: 'minimal' } },

Steps to reproduce

{ name: 'page-not-found', path: '*', component: ErrorPage, meta: { layout: 'minimal' } just change the layout from default to minimal

What version of Vue Storefront are you using?

1.12.3

What version of Node.js are you using?

12.0.0

What browser (and version) are you using?

Chrome

What operating system (and version) are you using?

Windows

Relevant log output

No response

Able to fix / change the documentation?

Code of Conduct