search

vuestorefront / vue-storefront-api

Vue.js storefront for Magento2 (and not only) - data backend
https://www.vuestorefront.io
MIT License
348 stars 338 forks source link

Add support for SVG files #505

Open ThermScissorpunch opened 4 years ago

ThermScissorpunch commented 4 years ago

The VSF API doesn't process SVG files. It simply returns an empty response. Since SVG files are vector I skipped the resize and cropping and return the SVG files as they are originally, using the toString method because they need to be returned as text.

pkarw commented 4 years ago

That's cool and it makes all the sense, please just fix the conflicts and we can merge it

gibkigonzo commented 4 years ago

@ThermScissorpunch Can you update branch, please?

ThermScissorpunch commented 4 years ago

Any idea how to fix this? When I merge in develop from the Divante branch I get the following message: fatal: refusing to merge unrelated histories

gibkigonzo commented 4 years ago

Normally I would remove local branch, create new one from develop, cherry-pick changes from remote and force push new branch. But here we have master branch. If you can please close this pre and create new one from develop branch

Fifciu commented 4 years ago

Hello @ThermScissorpunch . It is really awesome PR but could you please resolve conflicts?