Remake order functionality non-deterministic behavior

Zanuff commented 5 years ago

Current behavior

Remake order functionality ends up with random number of products in cart if not locked on backend side. Probably due to the asynchronicity of the requests.

Expected behavior

Remake order functionality should end up with the same number of products in cart after clicking remake order.

Steps to reproduce the issue

Have an account with orders
Have an order with multiple products added
Go to my orders and click remake order
See how the cart id updated several times and end up with different number of tiems and totals

Can you handle fixing this bug by yourself?

[ ] YES
[x] NO

Which Release Cycle state this refers to? Info for developer.

Pick one option.

[ ] This is a bug report for test version on https://test.storefrontcloud.io - In this case Developer should create branch from develop branch and create Pull Request 2. Feature / Improvement back to develop.
[ ] This is a bug report for current Release Candidate version on https://next.storefrontcloud.io - In this case Developer should create branch from release branch and create Pull Request 3. Stabilisation fix back to release.
[x] This is a bug report for current Stable version on https://demo.storefrontcloud.io and should be placed in next stable version hotfix - In this case Developer should create branch from hotfix or master branch and create Pull Request 4. Hotfix back to hotfix.

alinadivante commented 5 years ago

Something is wrong when I try remake really big order (94 items).. Look at minicart-counter big_order

pkarw commented 5 years ago

Ok, it’s on the branch 2513 right?

alinadivante commented 5 years ago

Yes @pkarw - feature/2513

pkarw commented 5 years ago

OK, I've refactored it a little bit https://github.com/DivanteLtd/vue-storefront/pull/2887

alinadivante commented 5 years ago

Nice job!

alinadivante commented 5 years ago

@pkarw I tested it again, after merging, but now I see a problem with a duplicate notification and it takes a while before the user is redirected to the checkout. See my new video. big_order

Imho there should be loader displayed or information about the processing.

pkarw commented 5 years ago

OK, we need to add the check for duplicated notification in the core/modules/cart/store/actions.ts:583

pkarw commented 5 years ago

I've also got a console error: vuex.esm.js:410 [vuex] unknown action type: cart/getPaymentMethods

pkarw commented 5 years ago

Check also the forceServerSync when entering Checkout.js. Currently it is set with the remake order - and probable shouldn't be (it will save us on cart sync)

pkarw commented 5 years ago

Plus as @alinadivante wrote - adding a popup / blocking loader

vuestorefront / vue-storefront