Closed lukeromanowicz closed 4 years ago
As it may sound easy with the events that have just a single listener (eg. https://github.com/DivanteLtd/vue-storefront/blob/20b693e28eeac810252593e1b42e709cc03701e9/core/modules/order/hooks/beforeRegistration.ts#L19) it's not so easy to replace EventBus for events that have multiple/dynamic listeners.
Let's say the events used by the payments modules (https://github.com/danrcoull/vsf-payment-braintree/blob/d42a2e6f2ccc227aad6c183ea8c089da032a73cb/hooks/beforeRegistration.ts#L25)
We need to have some proposal on how to handle the other cases
What is the motivation for adding / enhancing this feature?
As we are using vuex, there is no point in mixing it with an event bus. We should replace all events with actions while still dispatching events inside these actions for backward compatibility untill the next major release.
What are the acceptance criteria
Can you complete this feature request by yourself?
Which Release Cycle state this refers to? Info for developer.
Pick one option.
develop
branch and create Pull Request2. Feature / Improvement
back todevelop
.release
branch and create Pull Request3. Stabilisation fix
back torelease
.hotfix
ormaster
branch and create Pull Request4. Hotfix
back tohotfix
.Additional information