Closed bartoszherba closed 1 year ago
@WojtekTheWebDev I can prepare the release, but do we have a procedure of how to do that?
@bartoszherba I've changed base branch to chore/release-2.8.0-canary so we can merge this one. I'll take care of final release
Description
The goal of this task was to make the
onCreate
an async function. To achieve that we must introduce BC change. The most intrusive change is that theapiClientFactory
also becomes an async function.Because the
onCreate
function is strongly coupled with the factory and lifecycles, there is no other way to make it an async function but to make the whole creation process asynchronous.As a migration step, all
onCreate
functions inindex.server.ts
in all integrations must be updated to the async function. This is a huge change and will have an impact on all integrations.Motivation and Context
How Has This Been Tested?
I tested that for the Magento integration. Once the
onCreate
function was updated to the async function build and app started to work properly as before without any noticeable bugs or problems.Types of changes
Checklist:
Changelog
Tests
Code standards
Docs