vuestorefront / vue-storefront

Alokai is a Frontend as a Service solution that simplifies composable commerce. It connects all the technologies needed to build and deploy fast & scalable ecommerce frontends. It guides merchants to deliver exceptional customer experiences quickly and easily.
https://www.alokai.com
MIT License
10.59k stars 2.08k forks source link

feat!: make on create an async function #6807

Closed bartoszherba closed 1 year ago

bartoszherba commented 2 years ago

Description

The goal of this task was to make the onCreate an async function. To achieve that we must introduce BC change. The most intrusive change is that theapiClientFactory also becomes an async function.

Because the onCreate function is strongly coupled with the factory and lifecycles, there is no other way to make it an async function but to make the whole creation process asynchronous.

As a migration step, all onCreate functions in index.server.ts in all integrations must be updated to the async function. This is a huge change and will have an impact on all integrations.

Motivation and Context

How Has This Been Tested?

I tested that for the Magento integration. Once the onCreate function was updated to the async function build and app started to work properly as before without any noticeable bugs or problems.

Types of changes

Checklist:

Changelog

Tests

Code standards

Docs

bartoszherba commented 1 year ago

@WojtekTheWebDev I can prepare the release, but do we have a procedure of how to do that?

WojtekTheWebDev commented 1 year ago

@bartoszherba I've changed base branch to chore/release-2.8.0-canary so we can merge this one. I'll take care of final release