Accept to run node 18 - Githubissues

vuestorefront / vue-storefront

Alokai is a Frontend as a Service solution that simplifies composable commerce. It connects all the technologies needed to build and deploy fast & scalable ecommerce frontends. It guides merchants to deliver exceptional customer experiences quickly and easily.

https://www.alokai.com

MIT License

10.59k stars 2.08k forks source link

Accept to run node 18 #6845

Closed joncasdam closed 3 months ago

joncasdam commented 1 year ago

Accept to run node 18 and not only until Node 16

Description

Vue-Storefront doesn't allow Node 18 yet, this is related to https://github.com/vuestorefront/vue-storefront/issues/6844

Related Issue

Closes https://github.com/vuestorefront/vue-storefront/issues/6844

Motivation and Context

How Has This Been Tested?

Install succeeded when this patch was applied

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have read the CONTRIBUTING document.

Changelog

[x] I have updated the Changelog (V1) v2 and mentioned all breaking changes in the public API.
[x] I have documented all new public APIs and made changes to existing docs mentioning the parts I've changed so they're up to date.

Tests

[x] I have written test cases for my code
[x] I have tested my Pull Request on production build and (to my knowledge) it works without any issues
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

I tested manually my code, and it works well with both:
[x] Default Theme
[x] Capybara Theme

Code standards

[x] My code follows the code style of this project.
[x] I have followed naming conventions

Docs

[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.