New core repository - Githubissues

sethidden commented 1 year ago

This PR introduces the following major changes:

remove old middleware (nuxt-based) package and copy https://github.com/vuestorefront/middleware in its place (vuestorefront/middleware repo should be archived in the future)
copy https://github.com/vuestorefront/sdk to the repo (sdk repo should be archived)
remove all other packages except packages/cli (the removed packages are backed up on the legacy branch due to support reasons)

Minor/secondary changes:

start using unified ci/cd for all packages; align containing code with the integrations team eslint config etc.
setup sonarcloud for all 3 packages

internal ticket: IN-3345

gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [7561600](https://dashboard.gitguardian.com/incidents/7561600?occurrence=113715815) | Company Email Password | dabf89428e696e3857ed872a92e9c37818b8bb39 | packages/core/__tests__/factories/useUserFactory.spec.ts | [View secret](https://github.com/vuestorefront/vue-storefront/commit/dabf89428e696e3857ed872a92e9c37818b8bb39#diff-c6115d278200b21df87817134e099418d6d1ecf24c5b6ce843723b8ec2cc6c98L225) |

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/generics/company_email_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

github-advanced-security[bot] commented 1 year ago

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.