fix(ES-230): `buildModule` types in tsconfig strict mode - Githubissues

vuestorefront / vue-storefront

Alokai is a Frontend as a Service solution that simplifies composable commerce. It connects all the technologies needed to build and deploy fast & scalable ecommerce frontends. It guides merchants to deliver exceptional customer experiences quickly and easily.

https://www.alokai.com

MIT License

10.64k stars 2.08k forks source link

fix(ES-230): `buildModule` types in tsconfig strict mode #7064

Closed jagoral closed 8 months ago

jagoral commented 8 months ago

🔗 Linked issue

ES-230

❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme or JSDoc annotations)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Fixed buildModule types in strict mode
Added typescript-strict-plugin, to be able to use strict mode partially in the package, and add tests for strict mode
Tested locally with linked version in unified-storefronts repo

📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

changeset-bot[bot] commented 8 months ago

🦋 Changeset detected

Latest commit: 35adb29bde2d77b095d005afa045dbf75531d9e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ------------------- | ----- | | @vue-storefront/sdk | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Tofandel commented 8 months ago

This broke the rest of the typescript builds, now typescript always fails if only 1 param is given to buildModule