search

vuestorefront / vue-storefront

Alokai is a Frontend as a Service solution that simplifies composable commerce. It connects all the technologies needed to build and deploy fast & scalable ecommerce frontends. It guides merchants to deliver exceptional customer experiences quickly and easily.
https://www.alokai.com
MIT License
10.64k stars 2.08k forks source link

IN-4062 Consolidate engineering-toolkit #7107

Closed sethidden closed 7 months ago

sethidden commented 7 months ago

Move packages from vuestorefront/engineering-toolkit to this repo as part of the repo consolidation initative.

changeset-bot[bot] commented 7 months ago

🦋 Changeset detected

Latest commit: f3e2549bdb8caa270dd6f8e0c706183bf1e82460

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------------------- | ----- | | @vue-storefront/eslint-config | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

gitguardian[bot] commented 7 months ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [7305177](https://dashboard.gitguardian.com/incidents/7305177?occurrence=128849540) | Triggered | Basic Auth String | e8e4cbfd61f610434d6db390647493b441b989db | engineering-toolkit/github-actions/check-licenses/dist/index.js | [View secret](https://github.com/vuestorefront/vue-storefront/commit/e8e4cbfd61f610434d6db390647493b441b989db#diff-616e7747823bb4e6e612045053cd64318d79646e7b213b0b5ce23f2f520982d8R11248) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/specifics/private_key_openssh#revoke-the-secret). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

sethidden commented 7 months ago

GitGuardian is complaining about an example comment

image