vuetifyjs / create

🛠️ Build tooling for Vuetify 3
60 stars 18 forks source link

fix the include pattern in tsconfig template #48

Closed ForgottenR closed 2 months ago

ForgottenR commented 4 months ago

Code intellisense in IDE doesn't work (such as the "@" path resolution) because of the wrong include pattern in the tsconfig.json file.

johnleider commented 3 months ago

Is the include necessary in this instance while using exclude?

ForgottenR commented 3 months ago

Is the include necessary in this instance while using exclude?

From my own experience, for a pure TypeScript project leaving include out may be enough, since the default pattern is **/* (see the tsconfig doc). Sometimes we still need to specify the include configuration because we want to split the project into different scopes for typescript to do type checking with different configuration, which is quite typical for a web frontend project where there are configuration files (such as vite.config.ts, babel.config.js, etc. ) which is referenced during build time with node environment.

For a Vue project however, we always need to specify the include configuration to enable type checking (only during develop time for ide and maybe some linters since the actual files bundled are specified by vite configuration instead) and code intellisense for .vue files which I believe is not included with the **/* pattern. And since include overwrites instead of appending to the default configuration, we need to specify a pattern that includes all files of the app.

Livan-pro commented 1 month ago

Would be nice to release a new version with this fix :slightly_smiling_face:

johnleider commented 1 month ago

Would be nice to release a new version with this fix 🙂

My apologies for the delay. Just released