vuetifyjs / eslint-plugin-vuetify

An eslint plugin for Vuetify
Other
120 stars 26 forks source link

`v-slider` incorrectly reports ticks as no-deprecated-props #69

Closed MaximeGrimler closed 1 year ago

MaximeGrimler commented 1 year ago

Hello,

According to the upgrade guide ticks has been renamed to show-ticks and tick-labels to ticks (https://vuetifyjs.com/en/getting-started/upgrade-guide/#v-slider-v-range-slider)

Nevertheless when using ticks I think he doesn't understand that we want to use the new prop (which replace tick-labels) but the old one as he always report an error on it image

Is there any way to fix it?

Thanks!

KaelWD commented 1 year ago

eslint runs rules multiple times, if we autofix this then tick-labels will also be replaced with show-ticks

MaximeGrimler commented 1 year ago

Maybe not autofixing it but for example if ticks is a boolean or "always" (type of show-ticks which had been deprecated) then throw an error ? Else consider we use the new notation (which is the old one from tick-labels) and don't throw any error.

Because currently I'm forced to deactivate the rule no-deprecated-props for that component as it looks like a circular error

KaelWD commented 1 year ago

if ticks is a boolean or "always" (type of show-ticks which had been deprecated) then throw an error

We don't know what labels is. I'm going to count this as basically the same as #59