vuetifyjs / nuxt

Nuxt.js + Vuetify.js starter project template.
MIT License
306 stars 109 forks source link

Fix a-la-carte components and eslint for Nuxt v2 #60

Closed XanderLuciano closed 5 years ago

XanderLuciano commented 5 years ago

I noticed a few issues from @Codefa's PR #56 and spent a little time fixing all the various errors that were appearing in Nuxt v2.

To test this PR, just specify the nuxt2 branch from my repo.

$ vue init XanderLuciano/nuxt#nuxt2 my-project

Error free a-la-carte :)

image

XanderLuciano commented 5 years ago

This PR will resolve #56, #58, and #59.

As well as resolving issues #54 and #37.

XanderLuciano commented 5 years ago

Note: It's recommended to use vuetify-loader for vuetify from 1.3.0 on - https://github.com/vuetifyjs/vuetify/issues/3496#issuecomment-427077294

I'll have to play around with vuetify-loader later on and see about replacing the configuration here with it. But for now this PR should take care of a few issues since a-la-carte components don't even work with this template out of the box currently.

Codefa commented 5 years ago

@XanderLuciano Please merge all these fixes to your forked repository let me test your forked vuetify/nuxt repository

XanderLuciano commented 5 years ago

Merged to XanderLuciano/nuxt:master

You can test with the following command:

$ vue init XanderLuciano/nuxt my-project
XanderLuciano commented 5 years ago

image

Just wanted to document where .isClient and isServer are said to be deprecated.

Context API

XanderLuciano commented 5 years ago

This was wrong. The context API shown above is separate form the extend build context.

Codefa commented 5 years ago

This was wrong. The context API shown above is separate form the extend build context.

See nuxt starter template is deprecated must use create-nuxt-app

XanderLuciano commented 5 years ago

That's fine, I just didn't want to lead any future googlers down the wrong path over such a small misunderstanding and simple 3 line fix.